Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104786: Remove kwargs-based TypedDict creation #104891

Merged
merged 10 commits into from
May 25, 2023
Merged

gh-104786: Remove kwargs-based TypedDict creation #104891

merged 10 commits into from
May 25, 2023

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented May 24, 2023 •
edited by bedevere-bot
Loading

Not sure if/how I should update the docs:

cpython/Doc/library/typing.rst

Lines 1783 to 1785 in c90a862

.. deprecated-removed:: 3.11 3.13
The keyword-argument syntax is deprecated in 3.11 and will be removed
in 3.13. It may also be unsupported by static type checkers.

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Could you also add a note to https://github.com/python/cpython/blob/main/Doc/whatsnew/3.13.rst#removed?

@AlexWaygood
Copy link
Member

AlexWaygood commented May 24, 2023 •
edited
Loading

Not sure if/how I should update the docs:

I would remove the existing deprecated-removed note, and add something like:

.. versionchanged:: 3.13
   Removed support for the keyword-argument method of creating ``TypeDict``\s.

AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Doc/library/typing.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@tomasr8 @AlexWaygood
Update Doc/whatsnew/3.13.rst
6d2ae81 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Doc/library/typing.rst Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood mentioned this pull request May 25, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Doc/library/typing.rst Outdated Show resolved Hide resolved
Doc/library/typing.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Lib/typing.py Outdated Show resolved Hide resolved
tomasr8 and others added 2 commits May 25, 2023 21:37
@tomasr8 @AlexWaygood
Improve wording
7dae0e7 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@tomasr8
Remove mention of Python 3.6
eb94f7b
AlexWaygood
AlexWaygood approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks @tomasr8!

@AlexWaygood AlexWaygood requested a review from JelleZijlstra May 25, 2023 20:12
@AlexWaygood AlexWaygood merged commit fea8632 into python:main May 25, 2023
@tomasr8 tomasr8 deleted the typeddict-kwargs-removal branch May 25, 2023 20:18
@tomasr8
Copy link
Member Author

tomasr8 commented May 25, 2023

Thanks for the reviews!

@tomasr8 tomasr8 mentioned this pull request May 25, 2023
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomasr8 @AlexWaygood @JelleZijlstra @bedevere-bot