-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] gh-103921: Improve typing documentation (GH-104642) #105007
Merged
JelleZijlstra
merged 3 commits into
python:3.11
from
JelleZijlstra:backport-060277d-3.11
May 27, 2023
Merged
[3.11] gh-103921: Improve typing documentation (GH-104642) #105007
JelleZijlstra
merged 3 commits into
python:3.11
from
JelleZijlstra:backport-060277d-3.11
May 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
requested review from
gvanrossum,
Fidget-Spinner and
AlexWaygood
as code owners
May 27, 2023 01:25
This was referenced May 27, 2023
Closed
AlexWaygood
reviewed
May 27, 2023
Thanks Alex! Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
May 27, 2023
AlexWaygood
requested changes
May 27, 2023
When you're done making the requested changes, leave the comment: |
AlexWaygood
reviewed
May 27, 2023
AlexWaygood
approved these changes
May 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 060277d)
This backports some of the changes from the PEP 695 documentation PR (#104642) to 3.11, because I ended up making some improvements that are also applicable to older versions of typing:
typing.rst
📚 Documentation preview 📚: https://cpython-previews--105007.org.readthedocs.build/