Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Precompute hash for config cache key in check_source job #105008

Merged
merged 1 commit into from
May 27, 2023
Merged

CI: Precompute hash for config cache key in check_source job #105008

merged 1 commit into from
May 27, 2023

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented May 27, 2023

Followup to gh-104800, since all the build jobs already depend on the check_source job, we can precompute the hash in that job and reuse it in the downstream jobs.

While the time saving is negligible, the main benefit of this change is that the list of hashed files is not repeated in multiple places.

@itamaro itamaro mentioned this pull request May 27, 2023
Merged
hugovk
hugovk approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks!

@hugovk hugovk merged commit 949f0f5 into python:main May 27, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels May 27, 2023
@miss-islington
Copy link
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @itamaro and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.11

@miss-islington
Copy link
Contributor

Sorry @itamaro and @hugovk, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.12

@hugovk
Copy link
Member

hugovk commented May 27, 2023 •
edited
Loading

@itamaro Please could you backport these to 3.12 and 3.11?

@hugovk hugovk added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels May 27, 2023
@miss-islington
Copy link
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105014 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@itamaro @miss-islington
CI: Precompute hash for config cache key in check_source job (pythonG…
a6c1b67 
…H-105008)

(cherry picked from commit 949f0f5)

Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 27, 2023
@hugovk hugovk mentioned this pull request May 27, 2023
Merged
hugovk pushed a commit that referenced this pull request May 27, 2023
@miss-islington @itamaro
[3.12] CI: Precompute hash for config cache key in check_source job (G…
edd0cb8 
…H-105008) (#105014)

Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
@bedevere-bot
Copy link

GH-105024 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
@itamaro itamaro mentioned this pull request May 27, 2023
Merged
itamaro added a commit to itamaro/cpython that referenced this pull request May 27, 2023
@itamaro
[3.11] CI: Precompute hash for config cache key in check_source job (p…
40532b0 
…ythonGH-105008)

Backport of pythongh-105014 to 3.11

(manually cherry picked from commit 949f0f5)
hugovk pushed a commit that referenced this pull request May 27, 2023
@itamaro
[3.11] CI: Precompute hash for config cache key in check_source job (G…
d1a7d66 
…H-105008) (#105024)
@erlend-aasland
Copy link
Contributor

Nice; thanks!

@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@itamaro itamaro deleted the precompute-config-hash branch April 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@hugovk hugovk

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@itamaro @miss-islington @hugovk @bedevere-bot @erlend-aasland @arhadthedev