gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API #105072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation in the unstable API
iritkatriel
commented
May 30, 2023
iritkatriel
commented
May 30, 2023
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
iritkatriel
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 784b102 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
iritkatriel
added
needs backport to 3.12
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry @iritkatriel, I had trouble checking out the |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
May 30, 2023
…except* implementation in the unstable API (pythonGH-105072) (cherry picked from commit b7aadb4) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-105095 is a backport of this pull request to the 3.12 branch. |
|
GH-105095 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not rename the internal function, but rather added an API function that calls it. This is because the internal function can make more assumptions about the input than an API function (so the API function raises exceptions on things that the internal function just asserts).
Fixes #105071.
CC @da-woods .
📚 Documentation preview 📚: https://cpython-previews--105072.org.readthedocs.build/