gh-102251: Explicitly free state for test modules with state in test_import #105085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunmy2019
requested review from
brettcannon,
encukou,
ncoghlan and
warsaw
as code owners
|
Can you update the PR title to reflect the actual change? |
sunmy2019
changed the title
test_import_testsinglephase_with_state
sunmy2019
commented
May 30, 2023
sunmy2019
commented
May 30, 2023
sunmy2019
commented
May 30, 2023
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 26a9ede 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
erlend-aasland
changed the title
_testsinglephase_with_state
erlend-aasland
approved these changes
May 31, 2023
|
Approved by Eric in #104796 (review), as part of a larger PR. |
|
Thanks @sunmy2019 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2023
… test_import (pythonGH-105085) (cherry picked from commit a99b9d9) Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-105170 is a backport of this pull request to the 3.12 branch. |
erlend-aasland
added a commit
that referenced
this pull request
May 31, 2023
sunmy2019
added a commit
to sunmy2019/cpython
that referenced
this pull request
Jun 1, 2023
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module state is not cleared in the clean-up functions. This PR adds one clean-up function for it.
This fixes the second issue mentioned in #103879 (comment)