gh-105035: fix super() calls on unusual types (e.g. meta-types) #105094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
May 30, 2023
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
May 30, 2023
Summary: This bug was discovered in the upstream `LOAD_SUPER_ATTR` implementation in 3.12b1, and it also exists in the Cinder implementation. `_PyObject_GetMethod` checks whether the type has a non-standard `tp_getattro` (i.e. not `PyObject_GenericGetAttr`), and if so, refuses to attempt the load-method optimization. We didn't have this check in the `super()` optimization, causing incompatible behavior in the case of a `super()` lookup on a type with unusual `tp_getattro`, e.g. meta-types. Upstream fix is python/cpython#105094 Reviewed By: mpage Differential Revision: D46281340 fbshipit-source-id: 41aba762d3e2925042a3d897a690317ba2767cf2
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110) pythongh-105071: add missing versionadded directive (python#105097) pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904) pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093) pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
|
Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2023
…pythonGH-105094) (cherry picked from commit 68c75c3) Co-authored-by: Carl Meyer <carl@oddbird.net>
|
GH-105117 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LOAD_SUPER_ATTRoptimization was missing the check (found in_PyObject_GetMethod) to restrict the load-method optimization to lookups only against types that usePyObject_GenericGetAttrfor theirtp_getattro. This excludes, for example, meta-types, which have their owntp_getattroimplementation (_Py_type_getattro).super()#105035