Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101524: Only Use Public C-API in the _xxsubinterpreters Module #105258

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 2, 2023

The _xxsubinterpreters module was meant to only use public API. Some internal C-API usage snuck in over the last few years (e.g. gh-28969). This fixes that.

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner June 2, 2023 22:28
@ericsnowcurrently ericsnowcurrently removed the request for review from a team June 2, 2023 22:28
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) June 2, 2023 22:30
@ericsnowcurrently ericsnowcurrently merged commit e6373c0 into python:main Jun 2, 2023
@ericsnowcurrently ericsnowcurrently deleted the _xxsubinterpreters-public-api-only branch June 2, 2023 23:11
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.12 bug and security fixes label Jul 26, 2023
@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107303 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
…le (pythongh-105258)

The _xxsubinterpreters module was meant to only use public API.  Some internal C-API usage snuck in over the last few years (e.g. pythongh-28969).  This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit that referenced this pull request Jul 27, 2023
…ule (gh-105258) (gh-107303)

The _xxsubinterpreters module was meant to only use public API.  Some internal C-API usage snuck in over the last few years (e.g. gh-28969).  This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants