Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105390: Correctly raise TokenError instead of SyntaxError for tokenize errors #105399

Merged
merged 2 commits into from
Jun 7, 2023
Merged

gh-105390: Correctly raise TokenError instead of SyntaxError for tokenize errors #105399

merged 2 commits into from
Jun 7, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 6, 2023 •
edited by github-actions bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 6, 2023 16:11
@pablogsal pablogsal added the needs backport to 3.12 bug and security fixes label Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Closed
@pablogsal pablogsal force-pushed the gh-105390 branch 2 times, most recently from 06debb5 to 98d4d62 Compare June 6, 2023 16:22
pablogsal
pablogsal commented Jun 7, 2023
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
pablogsal
pablogsal commented Jun 7, 2023
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@pablogsal pablogsal merged commit ffd2654 into python:main Jun 7, 2023
@pablogsal pablogsal deleted the gh-105390 branch June 7, 2023 11:04
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105439 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@pablogsal @miss-islington
pythongh-105390: Correctly raise TokenError instead of SyntaxError fo…
0cc4225 
…r tokenize errors (pythonGH-105399)

(cherry picked from commit ffd2654)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal pushed a commit that referenced this pull request Jun 7, 2023
@miss-islington
[3.12] gh-105390: Correctly raise TokenError instead of SyntaxError f…
c84d4d1 
…or tokenize errors (GH-105399) (#105439)
@Eclips4 Eclips4 mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @miss-islington @bedevere-bot