Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104269: Document glob.glob duplicates when using multiple ** patterns #105406

Merged
merged 11 commits into from
Apr 11, 2024
Merged

gh-104269: Document glob.glob duplicates when using multiple ** patterns #105406

merged 11 commits into from
Apr 11, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jun 6, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Closed
@tomasr8
Copy link
Member Author

tomasr8 commented Jul 23, 2023

Just adding a comment here as well - The style guide says to use italics for parameters instead of literals

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 23, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@tomasr8
Copy link
Member Author

tomasr8 commented Jul 23, 2023

Hi @barneygale! Would you mind having a look at this? Thank you :)

evildmp
evildmp suggested changes Jul 23, 2023
View reviewed changes
Doc/library/glob.rst Show resolved Hide resolved
@barneygale barneygale self-requested a review July 24, 2023 16:30
barneygale
barneygale requested changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late feedback.

Doc/library/glob.rst Outdated Show resolved Hide resolved
Doc/library/glob.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Documentation/2023-06-06-21-18-14.gh-issue-104269.uP1hVC.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale barneygale added skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jan 20, 2024
@tomasr8
Copy link
Member Author

tomasr8 commented Jan 20, 2024

Sorry for the very late feedback.

Better late than never ;)

tomasr8 and others added 2 commits January 22, 2024 09:59
@tomasr8 @barneygale
Improve wording
fe34443 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@tomasr8
Remove news entry
75d8eaf
@tomasr8
Copy link
Member Author

tomasr8 commented Jan 22, 2024

I have made the requested changes; please review again

@tomasr8
Copy link
Member Author

tomasr8 commented Feb 6, 2024

Hmm seems like bedevere did not pick up that comment :/ @barneygale

@hugovk hugovk removed the needs backport to 3.11 only security fixes label Apr 11, 2024
@hugovk hugovk requested a review from barneygale April 11, 2024 14:09
@barneygale
Copy link
Contributor

My apologies once again for the long wait. Thank you for the patch, this looks good.

@barneygale barneygale enabled auto-merge (squash) April 11, 2024 15:04
@barneygale barneygale merged commit c06be6b into python:main Apr 11, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2024
@tomasr8 @miss-islington
pythongh-104269: Document glob.glob duplicates when using multiple …
364cd66 
…`**` patterns (pythonGH-105406)

(cherry picked from commit c06be6b)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 11, 2024

GH-117757 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 11, 2024
@tomasr8 tomasr8 deleted the glob-duplicates branch April 11, 2024 15:20
barneygale pushed a commit that referenced this pull request Apr 11, 2024
@miss-islington @tomasr8
[3.12] gh-104269: Document glob.glob duplicates when using multiple…
84fb531 
… `**` patterns (GH-105406) (#117757)

gh-104269: Document `glob.glob` duplicates when using multiple `**` patterns (GH-105406)
(cherry picked from commit c06be6b)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@tomasr8 @diegorusso
pythongh-104269: Document glob.glob duplicates when using multiple …
4c350d2 
…`**` patterns (python#105406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneygale barneygale barneygale approved these changes

@evildmp evildmp evildmp approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomasr8 @barneygale @evildmp @hugovk @bedevere-bot