Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_types: Replace raw assert statements #105500

Merged
merged 1 commit into from
Jun 8, 2023
Merged

test_types: Replace raw assert statements #105500

merged 1 commit into from
Jun 8, 2023

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra JelleZijlstra requested a review from sobolevn June 8, 2023 14:14
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 8, 2023
@JelleZijlstra
Copy link
Member Author

(Changing this because while working on #105499 I got an uninformative failure from one of these asserts.)

@JelleZijlstra JelleZijlstra merged commit a8eb737 into python:main Jun 8, 2023
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the testtypes branch June 8, 2023 14:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@JelleZijlstra @miss-islington
test_types: Replace raw assert statements (pythonGH-105500)
60bc83d 
(cherry picked from commit a8eb737)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-105507 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@JelleZijlstra @miss-islington
test_types: Replace raw assert statements (pythonGH-105500)
cce1b96 
(cherry picked from commit a8eb737)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-105508 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 8, 2023
JelleZijlstra added a commit that referenced this pull request Jun 8, 2023
@miss-islington @JelleZijlstra
[3.12] test_types: Replace raw assert statements (GH-105500) (#105507)
1f90b2f 
(cherry picked from commit a8eb737)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull request Jun 8, 2023
@miss-islington @JelleZijlstra
[3.11] test_types: Replace raw assert statements (GH-105500) (#105508)
b073b30 
(cherry picked from commit a8eb737)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra restored the testtypes branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JelleZijlstra @miss-islington @bedevere-bot @sobolevn @AlexWaygood