gh-105983: Add private mode support to webbrowser #105984

kr-g · 2023-06-22T09:08:45Z

Support incognito / private browsing.

Issue: Support private mode in webbrowser #105983

support for incognito / private browsing

bedevere-bot · 2023-06-22T09:08:49Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

default value set in base class

arhadthedev · 2023-06-22T10:00:05Z

@sobolevn @zooba (as recent committers into Lib/webbrowser.py)

removed %incognito since using %action for the implementation

kr-g · 2023-06-22T10:40:06Z

tested on linux with

chromium
firefox
epiphany

opera opens automatically with a private tab.
konqueror seams not offer such a feature.

sobolevn

Thanks a lot for the feature suggestion.

I will take another look when you will remove unrelated changes :)

Lib/webbrowser.py

Misc/NEWS.d/next/Security/2023-06-22-09-14-45.gh-issue-105983.7osoHj.rst

…7osoHj.rst Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

sobolevn

Please, also add tests for browsers that support it. And a doc note about this new feature.

Thank you for the quick response! 👍

sobolevn · 2023-06-22T11:39:29Z

Lib/webbrowser.py

@@ -604,6 +657,14 @@ def main():
    for o, a in opts:
        if o == '-n': new_win = 1
        elif o == '-t': new_win = 2
+        elif o == "-i":
+            new_win = 3
+        elif o == "-b":


Why do we have -b and -l added? I am not opposed to this, but again: this feature is not related.

If you feel like adding this feature is a good idea (it looks like it might be), please open a new issue: explain the use-case and the "why".

But, let's keep this PR simple: only incognito mode.

it is related to the cmdline interface when webbroser main() func is called.
they belong also to the newly added incognito method.
therefore it is not a new feature from my perspective.

This is not resolved at all. These are separate new additions.

We do appreciate your contribution here!
As the PR author, you are in the best place to address the review by removing the code added to support --browser.
That can be discussed in a separate issue. But if you don’t have the time, then someone else could complete the PR.

for me this is a migration topic. the experts do know better what to do here. myself i dont see here in the working loop since i dont have this detailed knowledge of what being best on master code baseline

Sorry, I don’t understand «migration». There are clear requests to remove some code that was added, to keep this PR focused on one thing. If you don’t want to pursue it, then someone else will have to volunteer.

kr-g · 2023-06-22T11:40:46Z

i would suggest that someone else will do auto formatting with black (PEP08)

Lib/webbrowser.py

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

kr-g · 2023-06-22T12:49:41Z

i followed the approach of the given tests under Lib/test/test_webbrowser.py and added some more for parameter checking (as far i understood that is how it works).

but since even the original tests i can not run here on my local machine (3 are failing) i created now a gist rather than releasing it.

https://gist.github.com/kr-g/95a06df8f0fcf77ad10474724350e921

terryjreedy

Remove stuff unrelated to the issue.

terryjreedy · 2023-06-22T20:00:26Z

Lib/webbrowser.py

@@ -604,6 +657,14 @@ def main():
    for o, a in opts:
        if o == '-n': new_win = 1
        elif o == '-t': new_win = 2
+        elif o == "-i":
+            new_win = 3
+        elif o == "-b":


This is not resolved at all. These are separate new additions.

bedevere-bot · 2023-06-22T20:01:11Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

into kr-g-browser-incognito

AmirNakhaeii · 2023-06-28T22:13:20Z

it is possible to fetch the PR to a local repo.

in case you dont know how:

please follow up here https://github.com/progit/progit2/releases -> search for "Pull Request Refs" (in release 2.1.404 it is from page 196 onwards).

the next section "Pull Requests on Pull Requests" describes how depending changes/ extensions can be made.

so ... for any other browser not covered so far (like e.g. MacOSXOSAScript mentioned by @ronaldoussoren) ... it would be great if the "finder" of that gap could provide also some code here.

Thanks

I fetched the this PR and I made some changes, but now how can I make the PR on this PR ?

gh-105983 merged contribution from amir for edge browser support

hugovk · 2023-06-30T15:13:33Z

Thanks for the update! Some things still to do (I unresolved the relevant threads):

Don't fallback to open_new, raise an exception instead
Remove -b and -l options
"Incognito" is more of a Google Chrome name, let's primarily name as "private", but can also mention "incognito" to help when searching (I can't seem to find where I earlier commented this...)

hugovk · 2023-09-19T05:48:50Z

@kr-g There's not much point updating this branch from main unless the unresolved items are addressed.

hugovk · 2023-10-18T15:13:48Z

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

kr-g · 2023-10-19T09:00:59Z

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

i use the branch - therefore i merge from time to time.
i m aware that you dont.
there is no reason to tell that in addition.
just unsubscribe. thanks.

kr-g · 2023-10-19T09:09:05Z

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

but anyway good to know the intention to kick me out of my own code.

AlexWaygood · 2023-10-19T10:51:52Z

Hi @kr-g, we have no intention of kicking you out of your own code :) However, by keeping a PR open against the CPython repo, you are indicating that this patch is something you are actively seeking to be merged into the main branch, and would like CPython maintainers to engage with. If you are not interested in addressing the comments of the reviewers here, that is your right, but you cannot expect for this PR to be kept open indefinitely.

If the PR is closed, the branch will not be deleted, and you will be able to continue using it locally. You will not be kicked out of your own code in any way. However, the PR will no longer show up as an active, open PR against the CPython repo that maintainers should engage with and attempt to review.

It sounds as though you are currently uninterested in addressing the comments of the reviewers here, so I'm going to close this. If I'm incorrect, and you are still interested in having this patch merged into the CPython main branch, please let us know, and we can reopen the PR :)

kr-g · 2023-10-19T11:39:25Z

i already said it some months ago that i see the "experts" here in charge to take over those topics because from my point of view thats an integration (or migration) issue to split the PR or rename a feature. i m not an expert and dont know what fits best on cpython baseline. but somehow this turns out to be ... well anyone can read and have an own idea about it.
there is no need to discuss further. also these lines are already too much.

AlexWaygood · 2023-10-19T11:52:48Z

CPython is an open-source project maintained by volunteers, who have limited time to help PRs make it over the finish line. I'm afraid it's the responsibility of the author of the PR to ensure that it's of a quality suitable to be merged, not the responsibility of the CPython core developers. We've given you advice on the changes that would be required to get this into a state where it could be merged; in this instance, that's as much as we can do.

kr-g · 2023-10-19T12:08:18Z

since i have doubled the webbrowser code already in my own project that all is not of importance to me. in case it comes somewhere in time i dont bother.
but as of today i m pissed off by the time used for this all.
i unsubscribe now from this thread and delete the repo on my side.
if someone whats to pick up the last word, or write sort of poetry. thats also fine with me.

browser incognito mode

814309a

support for incognito / private browsing

bedevere-bot added the awaiting review label Jun 22, 2023

📜🤖 Added by blurb_it.

2a67e33

AlexWaygood changed the title ~~webbrowser incognito mode~~ gh-105983: webbrowser incognito mode Jun 22, 2023

bedevere-bot mentioned this pull request Jun 22, 2023

Support private mode in webbrowser #105983

Closed

kr-g added 2 commits June 22, 2023 11:15

Merge branch 'main' into kr-g-browser-incognito

9d2fcfe

browser incognito mode

46d06d4

default value set in base class

removed unused flag

7baebe5

removed %incognito since using %action for the implementation

sobolevn requested changes Jun 22, 2023

View reviewed changes

Lib/webbrowser.py Outdated Show resolved Hide resolved

Lib/webbrowser.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Security/2023-06-22-09-14-45.gh-issue-105983.7osoHj.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Jun 22, 2023

kr-g and others added 3 commits June 22, 2023 13:24

reverted changes cause by formatting with black

b9079f4

Update Misc/NEWS.d/next/Security/2023-06-22-09-14-45.gh-issue-105983.…

f04f255

…7osoHj.rst Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

doc text

7eaa455

sobolevn reviewed Jun 22, 2023

View reviewed changes

Lib/webbrowser.py Outdated Show resolved Hide resolved

Update Lib/webbrowser.py

9e4ee59

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

kr-g requested a review from sobolevn June 22, 2023 12:50

terryjreedy requested changes Jun 22, 2023

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Jun 22, 2023

terryjreedy requested review from hugovk and zooba June 22, 2023 20:02

terryjreedy changed the title ~~gh-105983: webbrowser incognito mode~~ gh-105983: Support webbrowser incognito mode Jun 22, 2023

merwok changed the title ~~gh-105983: Support webbrowser private mode~~ gh-105983: Add private mode support to webbrowser Jun 26, 2023

kr-g added 3 commits June 27, 2023 07:49

added incognito mode documentation

a4657c7

Merge branch 'main' into kr-g-browser-incognito

0f4b11f

Merge branch 'kr-g-browser-incognito' of https://github.com/kr-g/cpython

9580689

into kr-g-browser-incognito

kr-g added 9 commits June 30, 2023 14:16

merged branch from amir

3684723

removed

2d7a9c5

Merge pull request #1 from kr-g/amir-contrib

993f387

gh-105983 merged contribution from amir for edge browser support

corrected incognito var

9bb7124

added missing help text

2130631

added microsoft edge to the browser list

f8364db

reworked browser list option

d1de67c

Merge branch 'python:main' into kr-g-browser-incognito

994fe23

Merge branch 'main' into kr-g-browser-incognito

a43bd63

kr-g added 3 commits July 18, 2023 08:47

Merge branch 'python:main' into kr-g-browser-incognito

3cd8d82

Merge branch 'python:main' into kr-g-browser-incognito

5f0afcb

Merge branch 'python:main' into kr-g-browser-incognito

9408b3a

Merge branch 'python:main' into kr-g-browser-incognito

394265c

AlexWaygood closed this Oct 19, 2023

hugovk mentioned this pull request Nov 3, 2023

Add section on keeping CI green python/devguide#1215

Merged

kr-g mentioned this pull request Oct 7, 2024

webbrowser: Add options for private mode #77119

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-105983: Add private mode support to webbrowser #105984

gh-105983: Add private mode support to webbrowser #105984

kr-g commented Jun 22, 2023 •

edited by terryjreedy

Loading

bedevere-bot commented Jun 22, 2023

arhadthedev commented Jun 22, 2023

kr-g commented Jun 22, 2023

sobolevn left a comment

sobolevn left a comment •

edited

Loading

sobolevn Jun 22, 2023

kr-g Jun 22, 2023

terryjreedy Jun 22, 2023

merwok Jun 22, 2023

merwok Jun 23, 2023

kr-g Jun 23, 2023

merwok Oct 18, 2023

kr-g commented Jun 22, 2023

kr-g commented Jun 22, 2023 •

edited

Loading

terryjreedy left a comment

terryjreedy Jun 22, 2023

bedevere-bot commented Jun 22, 2023

AmirNakhaeii commented Jun 28, 2023 •

edited

Loading

hugovk commented Jun 30, 2023

hugovk commented Sep 19, 2023

hugovk commented Oct 18, 2023

kr-g commented Oct 19, 2023

kr-g commented Oct 19, 2023

AlexWaygood commented Oct 19, 2023

kr-g commented Oct 19, 2023

AlexWaygood commented Oct 19, 2023

kr-g commented Oct 19, 2023

gh-105983: Add private mode support to webbrowser #105984

gh-105983: Add private mode support to webbrowser #105984

Conversation

kr-g commented Jun 22, 2023 • edited by terryjreedy Loading

bedevere-bot commented Jun 22, 2023

arhadthedev commented Jun 22, 2023

kr-g commented Jun 22, 2023

sobolevn left a comment

Choose a reason for hiding this comment

sobolevn left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kr-g commented Jun 22, 2023

kr-g commented Jun 22, 2023 • edited Loading

terryjreedy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bedevere-bot commented Jun 22, 2023

AmirNakhaeii commented Jun 28, 2023 • edited Loading

hugovk commented Jun 30, 2023

hugovk commented Sep 19, 2023

hugovk commented Oct 18, 2023

kr-g commented Oct 19, 2023

kr-g commented Oct 19, 2023

AlexWaygood commented Oct 19, 2023

kr-g commented Oct 19, 2023

AlexWaygood commented Oct 19, 2023

kr-g commented Oct 19, 2023

kr-g commented Jun 22, 2023 •

edited by terryjreedy

Loading

sobolevn left a comment •

edited

Loading

kr-g commented Jun 22, 2023 •

edited

Loading

AmirNakhaeii commented Jun 28, 2023 •

edited

Loading