gh-106232: Make timeit doc command lines compatible with Windows. #106296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command Prompt (CMD Shell) and older versions of PowerShell require double quotes and single quotes inside the string. This form also works on linux and macOS.
terryjreedy
added
docs
|
I tested revised lines by copy and pasting into Command Prompt. I tested "-form on macOS and other coredevs on linux and Windows-Bash. I checked all hits for 'python -m' in Doc/library, Doc/using/, Doc/tutorial and timeit hits were the only ones needing fixes. |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @terryjreedy, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 1, 2023
…s. (pythonGH-106296) Command Prompt (CMD Shell) and older versions of PowerShell require double quotes and single quotes inside the string. This form also works on linux and macOS. (cherry picked from commit 04dfc6f) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-106298 is a backport of this pull request to the 3.12 branch. |
terryjreedy
added a commit
that referenced
this pull request
Jul 1, 2023
…ws. (GH-106296) (#106298) gh-106232: Make timeit doc command lines compatible with Windows. (GH-106296) Command Prompt (CMD Shell) and older versions of PowerShell require double quotes and single quotes inside the string. This form also works on linux and macOS. (cherry picked from commit 04dfc6f) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
The 3.11 merge conflict is because 'python' was 'python3' in 3.11, and changed in 3.12. I am not going to backport. |
manosriram
pushed a commit
to manosriram/cpython
that referenced
this pull request
Jul 1, 2023
…s. (python#106296) Command Prompt (CMD Shell) and older versions of PowerShell require double quotes and single quotes inside the string. This form also works on linux and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.
📚 Documentation preview 📚: https://cpython-previews--106296.org.readthedocs.build/