Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106232: Make timeit doc command lines compatible with Windows. #106296

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 30, 2023

Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.


📚 Documentation preview 📚: https://cpython-previews--106296.org.readthedocs.build/

Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.
@terryjreedy
Copy link
Member Author

I tested revised lines by copy and pasting into Command Prompt. I tested "-form on macOS and other coredevs on linux and Windows-Bash. I checked all hits for 'python -m' in Doc/library, Doc/using/, Doc/tutorial and timeit hits were the only ones needing fixes.

@terryjreedy terryjreedy merged commit 04dfc6f into python:main Jul 1, 2023
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @terryjreedy, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 04dfc6fa9018e92a5b51c29fc0ff45419c596bc3 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2023
…s. (pythonGH-106296)

Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.
(cherry picked from commit 04dfc6f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-106298 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 1, 2023
@terryjreedy terryjreedy deleted the timeit branch July 1, 2023 02:35
terryjreedy added a commit that referenced this pull request Jul 1, 2023
…ws. (GH-106296) (#106298)

gh-106232: Make timeit doc command lines compatible with Windows. (GH-106296)

Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.
(cherry picked from commit 04dfc6f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy removed the needs backport to 3.11 only security fixes label Jul 1, 2023
@terryjreedy
Copy link
Member Author

The 3.11 merge conflict is because 'python' was 'python3' in 3.11, and changed in 3.12. I am not going to backport.

manosriram pushed a commit to manosriram/cpython that referenced this pull request Jul 1, 2023
…s. (python#106296)

Command Prompt (CMD Shell) and older versions of PowerShell
require double quotes and single quotes inside the string.
This form also works on linux and macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants