gh-105535 Document potential performance trap during enum creation #107119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
evildmp
reviewed
Jul 23, 2023
evildmp
approved these changes
Jul 23, 2023
hugovk
added
needs backport to 3.11
ethanfurman
reviewed
Jul 24, 2023
evildmp
suggested changes
Jul 24, 2023
ethanfurman
reviewed
Jul 24, 2023
|
Thoughts on making this an actual warning box? |
hugovk
reviewed
Jul 24, 2023
ethanfurman
reviewed
Jul 25, 2023
attempt to fix dataclass link
evildmp
approved these changes
Jul 26, 2023
ethanfurman
reviewed
Mar 4, 2024
ethanfurman
reviewed
Mar 4, 2024
hugovk
reviewed
Mar 5, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
@hugovk, thanks, I missed that those were the sunder versions when I merged them. |
hugovk
reviewed
Mar 5, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
Mar 6, 2024
|
Thanks @nicky-eng for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2024
…ion (pythonGH-107119) (cherry picked from commit 601f3a7) Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-116511 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2024
…ion (pythonGH-107119) (cherry picked from commit 601f3a7) Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-116512 is a backport of this pull request to the 3.11 branch. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ion (pythonGH-107119) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ion (pythonGH-107119) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #105535
Document potential performance trap during enum creation.
📚 Documentation preview 📚: https://cpython-previews--107119.org.readthedocs.build/