Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-46376: Return existing pointer when possible in ctypes #107131

Merged
merged 1 commit into from
Jul 31, 2023
Merged

gh-46376: Return existing pointer when possible in ctypes #107131

merged 1 commit into from
Jul 31, 2023

Conversation

code-of-kpp
Copy link
Contributor

@code-of-kpp code-of-kpp commented Jul 23, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Open
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

1 similar comment
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 23, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@code-of-kpp code-of-kpp changed the title gh-46376: Return existing pointer when possible in ctypes WIP gh-46376: Return existing pointer when possible in ctypes Jul 23, 2023
ambv
ambv reviewed Jul 23, 2023
View reviewed changes
Modules/_ctypes/_ctypes.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@code-of-kpp code-of-kpp force-pushed the ctypes-p2p branch 3 times, most recently from f0009ef to 36fb19a Compare July 24, 2023 16:30
@code-of-kpp code-of-kpp requested a review from ambv July 26, 2023 10:48
@code-of-kpp code-of-kpp changed the title WIP gh-46376: Return existing pointer when possible in ctypes gh-46376: Return existing pointer when possible in ctypes Jul 26, 2023
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 31, 2023
@ambv ambv merged commit 08447b5 into python:main Jul 31, 2023
@miss-islington
Copy link
Contributor

Thanks @code-of-kpp for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @code-of-kpp and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 08447b5deb47e2a0df87fa0a0576d300e5c909b4 3.12

@miss-islington
Copy link
Contributor

Sorry, @code-of-kpp and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 08447b5deb47e2a0df87fa0a0576d300e5c909b4 3.11

@ambv
Copy link
Contributor

ambv commented Jul 31, 2023

I'll backport disabled test removal first to make the conflicts go away. That's #107483 and #107484.

ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
@code-of-kpp @ambv
[3.12] pythongh-46376: Return existing pointer when possible in ctypes (
c38d425 
pythonGH-107131)

(cherry picked from commit 08447b5)

Co-authored-by: Konstantin <kpp.live+github@gmail.com>
@bedevere-bot
Copy link

GH-107487 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 31, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
@code-of-kpp @ambv
[3.11] pythongh-46376: Return existing pointer when possible in ctypes (
f099f3a 
pythonGH-107131)

(cherry picked from commit 08447b5)

Co-authored-by: Konstantin <kpp.live+github@gmail.com>
@bedevere-bot
Copy link

GH-107488 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2023
ambv added a commit that referenced this pull request Jul 31, 2023
@ambv @code-of-kpp
[3.12] gh-46376: Return existing pointer when possible in ctypes (GH-…
54aaaad 
…107131) (#107487)

(cherry picked from commit 08447b5)

Co-authored-by: Konstantin <kpp.live+github@gmail.com>
ambv added a commit that referenced this pull request Jul 31, 2023
@ambv @code-of-kpp
[3.11] gh-46376: Return existing pointer when possible in ctypes (GH-…
57f27e4 
…107131) (#107488)

(cherry picked from commit 08447b5)

Co-authored-by: Konstantin <kpp.live+github@gmail.com>
@mattip mattip mentioned this pull request Aug 14, 2023
Closed
2 tasks
ambv added a commit to ambv/cpython that referenced this pull request Aug 21, 2023
@ambv
Revert "[3.11] pythongh-46376: Return existing pointer when possible …
4760094 
…in ctypes (pythonGH-107131) (python#107488)"

This reverts commit 57f27e4.
ambv added a commit to ambv/cpython that referenced this pull request Aug 22, 2023
@ambv
Revert "[3.12] pythongh-46376: Return existing pointer when possible …
0d4c21d 
…in ctypes (pythonGH-107131) (python#107487)"

This reverts commit 54aaaad.
ambv added a commit to ambv/cpython that referenced this pull request Aug 24, 2023
@ambv
Revert "[3.11] pythongh-46376: Return existing pointer when possible …
b08996e 
…in ctypes (pythonGH-107131) (python#107488)"

This reverts commit 57f27e4.
ambv added a commit that referenced this pull request Aug 24, 2023
@ambv
[3.11] Revert "gh-46376: Return existing pointer when possible in cty…
c3d129f 
…pes (GH-107131) (GH-107488)" (#108412)

This reverts commit 57f27e4.

The fix caused gh-107940. Until we have a bulletproof fix for that, the 3.11 backport needs to be reverted to make way for 3.11.5.
vstinner added a commit to vstinner/cpython that referenced this pull request Aug 30, 2023
@vstinner
Revert "pythongh-46376: Return existing pointer when possible in ctyp…
8ae78bf 
…es (python#107131)"

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change,
commit 6726626.
ambv added a commit to ambv/cpython that referenced this pull request Sep 4, 2023
@ambv
Revert "[3.12] pythongh-46376: Return existing pointer when possible …
a6f728d 
…in ctypes (pythonGH-107131) (python#107487)"

This reverts commit 54aaaad.
ambv added a commit that referenced this pull request Sep 4, 2023
@ambv @Yhg1s
[3.12] gh-46376: Revert "Return existing pointer when possible in cty…
e0f6080 
…pes (GH-107131) (GH-107487)" (#108864)

This reverts commit 54aaaad.

Co-authored-by: T. Wouters <thomas@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv Awaiting requested review from ambv

Assignees

@ambv ambv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@code-of-kpp @bedevere-bot @miss-islington @ambv @s1kpp