Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107091: Fix some uses of :attr: role #107318

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 26, 2023

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor suggestion.

Doc/c-api/import.rst Outdated Show resolved Hide resolved
Doc/c-api/init.rst Outdated Show resolved Hide resolved
Doc/c-api/import.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit d363eb5 into python:main Jul 27, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-attr-role branch July 27, 2023 05:52
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d363eb5b0255c055e7b43f5e2c0847f555e1982e 3.12

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d363eb5b0255c055e7b43f5e2c0847f555e1982e 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2023
Fix also formatting of PyMethodDef members..
(cherry picked from commit d363eb5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-107330 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 27, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2023
Fix also formatting of PyMethodDef members..
(cherry picked from commit d363eb5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-107331 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2023
Fix also formatting of PyMethodDef members.
(cherry picked from commit d363eb5)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2023
Fix also formatting of PyMethodDef members.
(cherry picked from commit d363eb5)
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-C-API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants