Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: Rework Argument Clinic error handling #107551

Merged
merged 31 commits into from
Aug 3, 2023
Merged

gh-104683: Rework Argument Clinic error handling #107551

merged 31 commits into from
Aug 3, 2023

Commits on Jul 29, 2023

  1. Rework error handling 

    - Introduce ClinicError and ClinicWarning
- fail() raises ClinicError
- warn() uses warnings.warn(msg, ClinicWarning)
- the CLI runs main(), catches ClinicError, formats the error message
  prints to stderr and exits with an error
- adapt the test suite to work with ClinicError
    @erlend-aasland
    erlend-aasland committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    36bac55 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Merge branch 'main' into clinic/warn-and-fail

    @erlend-aasland
    erlend-aasland authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9cb2ce9 View commit details
    Browse the repository at this point in the history

  2. Adapt new test

    @erlend-aasland
    erlend-aasland committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    789f5ee View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    15a246b View commit details
    Browse the repository at this point in the history

  2. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e32d221 View commit details
    Browse the repository at this point in the history

  3. Align with Alex's changes

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4350ecc View commit details
    Browse the repository at this point in the history

  4. Address review: pass iso. ellipse

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ad5181a View commit details
    Browse the repository at this point in the history

  5. Address review: add return annotation

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    545e7b6 View commit details
    Browse the repository at this point in the history

  6. Address review: re.escape

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c978a6d View commit details
    Browse the repository at this point in the history

  7. Address review: fix test

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    33b038c View commit details
    Browse the repository at this point in the history

  8. Refactor: extract method parse_parameter_name()

    @erlend-aasland
    erlend-aasland committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7b631a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Address review: re.escape better

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    553cb6e View commit details
    Browse the repository at this point in the history

  2. Address review: UserWarning iso. Warning

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1514f63 View commit details
    Browse the repository at this point in the history

  3. Revert "Refactor: extract method parse_parameter_name()" 

    This reverts commit 7b631a3.
    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d3daef7 View commit details
    Browse the repository at this point in the history

  4. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    aa38570 View commit details
    Browse the repository at this point in the history

  5. Print debug stuff to stderr

    @AlexWaygood @erlend-aasland
    AlexWaygood authored and erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8f3750b View commit details
    Browse the repository at this point in the history

  6. Adapt test

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e8b8d7e View commit details
    Browse the repository at this point in the history

  7. Print to stdout instead of using warnings.warn

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    79b9859 View commit details
    Browse the repository at this point in the history

  8. Final touches

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    57eff9d View commit details
    Browse the repository at this point in the history

  9. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5b8dea9 View commit details
    Browse the repository at this point in the history

  10. Fix merge

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6f5cfae View commit details
    Browse the repository at this point in the history

  11. Try to produce correct line numbers in error messages

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3081729 View commit details
    Browse the repository at this point in the history

  12. Fixup CLI error formatting

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    716bda8 View commit details
    Browse the repository at this point in the history

  13. Fix reraise of ClinicError in parse()

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    af79481 View commit details
    Browse the repository at this point in the history

  14. Adjust tests again

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d109b63 View commit details
    Browse the repository at this point in the history

  15. Remove unused import

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ecbfe2c View commit details
    Browse the repository at this point in the history

  16. Mutate the exception 

    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    @erlend-aasland @AlexWaygood
    erlend-aasland and AlexWaygood authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    90e1bc9 View commit details
    Browse the repository at this point in the history

  17. Share more code between the warn() and fail() branches (#49)

    @AlexWaygood
    AlexWaygood authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7766c3d View commit details
    Browse the repository at this point in the history

  18. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3d9d6c6 View commit details
    Browse the repository at this point in the history

  19. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8573928 View commit details
    Browse the repository at this point in the history

  20. Add docstring to _expect_failure

    @erlend-aasland
    erlend-aasland committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    fcd4721 View commit details
    Browse the repository at this point in the history