Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: Argument Clinic: refactor format_docstring() #107623

Merged
merged 9 commits into from
Aug 8, 2023
Merged

gh-104683: Argument Clinic: refactor format_docstring() #107623

merged 9 commits into from
Aug 8, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 4, 2023 •
edited by bedevere-bot
Loading

Extract helper methods for formatting the signature and parameter
sections, and clean up the remaining function body.

@erlend-aasland
pythongh-104683: Argument Clinic: refactor format_docstring()
fd632eb 
Extract helper methods for formatting the signature and parameter
sections, and clean up the remaining function body.
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
7 tasks
AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland @AlexWaygood
Use splitlines() iso. comprehension
1d244dc 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
Copy link
Member

Looks like there's a bug somewhere -- CI is failing

@erlend-aasland
Copy link
Contributor Author

Looks like there's a bug somewhere -- CI is failing

Yes, splitlines() is not quite the same as the old comprehension :(

@erlend-aasland
Copy link
Contributor Author

I reverted the splitlines change.

AlexWaygood
AlexWaygood reviewed Aug 4, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland @AlexWaygood
Split, not splitlines
0902130 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This was referenced Aug 4, 2023
Closed
Closed
@erlend-aasland erlend-aasland mentioned this pull request Aug 4, 2023
Closed
@AlexWaygood AlexWaygood mentioned this pull request Aug 5, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Aug 7, 2023
Merged
AA-Turner
AA-Turner reviewed Aug 8, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
erlend-aasland and others added 3 commits August 8, 2023 08:52
@erlend-aasland @AA-Turner
Style
e3ff673 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@erlend-aasland
Merge branch 'main' into clinic/refactor-format-docstring
e041288
@erlend-aasland
Fix mypy
34729c2
AA-Turner
AA-Turner approved these changes Aug 8, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 8, 2023 20:43
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews, Adam and Alex!

@erlend-aasland erlend-aasland merged commit 7350738 into python:main Aug 8, 2023
15 of 16 checks passed
@erlend-aasland erlend-aasland deleted the clinic/refactor-format-docstring branch August 8, 2023 21:18
@erlend-aasland
Copy link
Contributor Author

That's strange; automerge continued through even though the Windows (x86) CI failed (apparently it failed then succeeded because some of the flakey tests were flakey).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants