Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: Argument Clinic: Use CConverter.length_name where possible #107638

Merged
merged 2 commits into from
Aug 4, 2023
Merged

gh-104683: Argument Clinic: Use CConverter.length_name where possible #107638

merged 2 commits into from
Aug 4, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 4, 2023 •
edited by bedevere-bot
Loading

Also make it a property.

@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
7 tasks
@erlend-aasland
Copy link
Contributor Author

Low-hanging fruit :)

AlexWaygood
AlexWaygood approved these changes Aug 4, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland @AlexWaygood
Address review: make it a cached property
6c37324 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 4, 2023 17:44
@erlend-aasland erlend-aasland merged commit 321f0f7 into python:main Aug 4, 2023
16 checks passed
@erlend-aasland erlend-aasland deleted the clinic/use-converter-length-name branch August 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot