Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104496: Use correct Tcl or Tk version in Tkinter tests #107688

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 6, 2023

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Aug 6, 2023
@serhiy-storchaka serhiy-storchaka changed the title gh-107687: Use correct Tcl or Tk version in Tkinter tests gh-104496: Use correct Tcl or Tk version in Tkinter tests Aug 6, 2023
@serhiy-storchaka serhiy-storchaka force-pushed the tests-tk-version branch 2 times, most recently from 5c385fb to 098ead2 Compare August 7, 2023 08:51
In future Tcl and Tk versions can be desynchronized.
@serhiy-storchaka serhiy-storchaka merged commit 3c8e8f3 into python:main Aug 7, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tests-tk-version branch August 7, 2023 11:11
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3c8e8f3ceeae08fc43d885f5a4c65a3ee4b1a2c8 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2023
…onGH-107688)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-107709 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 7, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2023
pythonGH-107688)

In future Tcl and Tk versions can be desynchronized..
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-107719 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 7, 2023
serhiy-storchaka added a commit that referenced this pull request Aug 7, 2023
…107688) (GH-107719)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
…107688) (#107709)

gh-104496: Use correct Tcl or Tk version in Tkinter tests (GH-107688)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants