Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-107674: Avoid allocating boxed ints for sys.settrace line events #107780

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 8, 2023

The benchmarks are noisy but show a 6% performance increase for coverage.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor comments, LGTM.

(I'm approving, assuming you'll address the comments before merging.)

Python/instrumentation.c Show resolved Hide resolved
Python/instrumentation.c Outdated Show resolved Hide resolved
@markshannon markshannon merged commit 37d8b90 into python:main Aug 10, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2023
…events (pythonGH-107780)

(cherry picked from commit 37d8b90)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot
Copy link

GH-107841 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 10, 2023
@markshannon markshannon deleted the tweak-ints-monitoring branch September 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants