Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95065: Produce nicer deprecation messages in Argument Clinic #107808

Merged
merged 4 commits into from
Aug 9, 2023
Merged

gh-95065: Produce nicer deprecation messages in Argument Clinic #107808

merged 4 commits into from
Aug 9, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 9, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 9, 2023
Closed
@erlend-aasland
Copy link
Contributor Author

@serhiy-storchaka: this will probably cause merge conflicts with your work on deprecating keyword arguments.

@erlend-aasland
Copy link
Contributor Author

(the Azure failure is unrelated; flakey test_concurrent_futures test)

@serhiy-storchaka
Copy link
Member

Thank you. Nice change.

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Serhiy; highly appreciated.

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 9, 2023 13:00
@erlend-aasland erlend-aasland mentioned this pull request Aug 9, 2023
Merged
AlexWaygood
AlexWaygood approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice indeed!

@erlend-aasland erlend-aasland merged commit 0a7f48b into python:main Aug 9, 2023
@erlend-aasland erlend-aasland deleted the clinic/nicer-deprecation-messages branch August 9, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @serhiy-storchaka @AlexWaygood @bedevere-bot