Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105857: Document that asyncio subprocess std{in,out,err} can be file handles #107986

Merged
merged 1 commit into from
Aug 22, 2023
Merged

gh-105857: Document that asyncio subprocess std{in,out,err} can be file handles #107986

merged 1 commit into from
Aug 22, 2023

Conversation

Hels15
Copy link
Contributor

@Hels15 Hels15 commented Aug 15, 2023 •
edited by AA-Turner
Loading

In the docs passing a filehandle isn't mentioned as an option. Looking at the underlying code, I see it definitely is supported there's a check for the parameter being an integer and the handle is used directly.

📚 Documentation preview 📚: https://cpython-previews--107986.org.readthedocs.build/

@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2023
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 15, 2023
@AA-Turner AA-Turner changed the title gh-105857 stdin/out can be filehandles -> added to docs(asyncio-eventloop.rst). gh-105857: Document that asyncio subprocess std{in,out,err} can be file handles Aug 17, 2023
@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Aug 17, 2023
@ambv ambv merged commit 13966da into python:main Aug 22, 2023
21 checks passed
@miss-islington
Copy link
Contributor

Thanks @Hels15 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @Hels15 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 13966da71b693b1fae1a8ef66e34e2f0a90ec6c0 3.11

@bedevere-bot
Copy link

GH-108332 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
@Hels15 @miss-islington
pythongh-105857: Document that asyncio subprocess std{in,out,err} can…
ae509e3 
… be file handles (pythonGH-107986)

stdin/out can be filehandles -> add to docs.
(cherry picked from commit 13966da)

Co-authored-by: Hadházy Tamás <85063808+Hels15@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 22, 2023
ambv pushed a commit that referenced this pull request Aug 22, 2023
@miss-islington @Hels15
[3.12] gh-105857: Document that asyncio subprocess std{in,out,err} ca…
3cdaa6a 
…n be file handles (GH-107986) (#108332)

(cherry picked from commit 13966da)

Co-authored-by: Hadházy Tamás <85063808+Hels15@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hels15 @miss-islington @bedevere-bot @ambv @AA-Turner