Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-101100: Only show GitHub check annotations on changed doc paragraphs (GH-108065) #108127

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 19, 2023

  • Only show GitHub check annotations on changed doc paragraphs
  • Improve check-warnings script arg parsing following Hugo's suggestions
  • Factor filtering warnings by modified diffs into helper function
  • Build docs on unmerged branch so warning lines match & avoid deep clone

(cherry picked from commit eb953d6)

Co-authored-by: C.A.M. Gerlach CAM.Gerlach@Gerlach.CAM
Co-authored-by: Hugo van Kemenade hugovk@users.noreply.github.com
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com


📚 Documentation preview 📚: https://cpython-previews--108127.org.readthedocs.build/

…ragraphs (pythonGH-108065)

* Only show GitHub check annotations on changed doc paragraphs
* Improve check-warnings script arg parsing following Hugo's suggestions
* Factor filtering warnings by modified diffs into helper function
* Build docs on unmerged branch so warning lines match & avoid deep clone

---------

(cherry picked from commit eb953d6)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to avoid the warning spam, fix the line numbers and allow them to be checked locally on this branch as well.

@Yhg1s Yhg1s merged commit 71e3581 into python:3.12 Aug 19, 2023
23 checks passed
@miss-islington miss-islington deleted the backport-eb953d6-3.12 branch August 19, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants