Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-108342: Make ssl TestPreHandshakeClose more reliable (GH-108370) #108407

Merged
merged 1 commit into from
Aug 24, 2023

Commits on Aug 24, 2023

  1. [3.9] pythongh-108342: Make ssl TestPreHandshakeClose more reliable (p…

    …ythonGH-108370)
    
    * In preauth tests of test_ssl, explicitly break reference cycles
      invoving SingleConnectionTestServerThread to make sure that the
      thread is deleted. Otherwise, the test marks the environment as
      altered because the threading module sees a "dangling thread"
      (SingleConnectionTestServerThread). This test leak was introduced
      by the test added for the fix of issue pythongh-108310.
    * Use support.SHORT_TIMEOUT instead of hardcoded 1.0 or 2.0 seconds
      timeout.
    * SingleConnectionTestServerThread.run() catchs TimeoutError
    * Fix a race condition (missing synchronization) in
      test_preauth_data_to_tls_client(): the server now waits until the
      client connect() completed in call_after_accept().
    * test_https_client_non_tls_response_ignored() calls server.join()
      explicitly.
    * Replace "localhost" with server.listener.getsockname()[0].
    (cherry picked from commit 592bacb)
    
    Co-authored-by: Victor Stinner <vstinner@python.org>
    vstinner authored and ambv committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d2920f8 View commit details
    Browse the repository at this point in the history