-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix sphinx warnings in threading.rst
#108684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Aug 30, 2023
hugovk
added
needs backport to 3.11
only security fixes
needs backport to 3.12
bug and security fixes
labels
Aug 30, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
Aug 30, 2023
Thanks! |
GH-108707 is a backport of this pull request to the 3.12 branch. |
GH-108708 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2023
) (cherry picked from commit 991e4e7) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2023
) (cherry picked from commit 991e4e7) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Aug 31, 2023
…108708) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original warnings:
Couple of comments:
_threading_local
module is not documented as a module in sphinxThread.__init__()
is used the same way in other places as well,__init__
is not documented in sphinxThreadGroup
does not exist at the momentTimer.start <Thread.start>
is used becauseTimer
isThread
subclass andTimer.start
is not documentedrelease
andacquire
are used as general conventions, not exact methods