Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix sphinx warnings in unittest.mock-examples.rst #108810

Merged
merged 3 commits into from
Sep 2, 2023
Merged

gh-101100: Fix sphinx warnings in unittest.mock-examples.rst #108810

merged 3 commits into from
Sep 2, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 2, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Sep 2, 2023
Open
@AlexWaygood AlexWaygood mentioned this pull request Sep 2, 2023
Merged
AlexWaygood
AlexWaygood approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 2, 2023
@AlexWaygood AlexWaygood merged commit 5141b1e into python:main Sep 2, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@AlexWaygood: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5141b1ebe07ad54279e0770b4704eaf76f24951d 3.12

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5141b1ebe07ad54279e0770b4704eaf76f24951d 3.11

@AlexWaygood
Copy link
Member

@sobolevn, are you okay to take care of the backports? :)

@bedevere-bot
Copy link

GH-108812 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 2, 2023
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 2, 2023
@sobolevn
[3.11] pythongh-101100: Fix sphinx warnings in `unittest.mock-example…
402a645 
…s.rst` (pythonGH-108810)

(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 2, 2023
@sobolevn
[3.12] pythongh-101100: Fix sphinx warnings in `unittest.mock-example…
d74e296 
…s.rst` (pythonGH-108810).

(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-108813 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Sep 2, 2023
AlexWaygood pushed a commit that referenced this pull request Sep 2, 2023
@sobolevn
[3.11] gh-101100: Fix sphinx warnings in unittest.mock-examples.rst (…
662d236 
…GH-108810) (#108812)

(cherry picked from commit 5141b1e)
Yhg1s pushed a commit that referenced this pull request Sep 2, 2023
@sobolevn @AlexWaygood
[3.12] gh-101100: Fix sphinx warnings in unittest.mock-examples.rst (…
c5ce34f 
…GH-108810) (#108813)

* [3.12] gh-101100: Fix sphinx warnings in `unittest.mock-examples.rst` (GH-108810).
(cherry picked from commit 5141b1e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

* Make the requested changes

---------

Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk Awaiting requested review from hugovk

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

@AlexWaygood AlexWaygood

Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @miss-islington @bedevere-bot @AlexWaygood