-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix sphinx warnings in turtle.rst
#109394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a better fix might be just to document tkinter.Canvas
in the tkinter
docs? I don't know much about tkinter, though,so maybe there's a reason why it's not documented currently :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right given the current state of tkinter docs. The tkinter widget docs were referred to external sources. Only the ttk widget are documented (and with a few error as I remember). This should be fixed, and there may be an issue, but it will be a big project to do right.
Thanks @sobolevn for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
(cherry picked from commit 21e80f4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-109416 is a backport of this pull request to the 3.12 branch. |
GH-109417 is a backport of this pull request to the 3.11 branch. |
If and when the tk widgets are documented, I (we) should hopefully remember to search .rst files for '!tkinter' to see where the '1' can/should be removed. |
(cherry picked from commit 21e80f4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
It was:
But, since
tkinter.Canvas
is not documented intkinter
, we cannot reference it.📚 Documentation preview 📚: https://cpython-previews--109394.org.readthedocs.build/