Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix Sphinx warnings in Doc/library/weakref.rst #109881

Merged
merged 1 commit into from
Sep 26, 2023
Merged

gh-101100: Fix Sphinx warnings in Doc/library/weakref.rst #109881

merged 1 commit into from
Sep 26, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 26, 2023 •
edited by github-actions bot
Loading

It used to be:

/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:112: WARNING: py:meth reference target not found: __del__
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:223: WARNING: py:meth reference target not found: keyrefs
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:281: WARNING: py:meth reference target not found: __del__
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:526: WARNING: py:meth reference target not found: __del__
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:534: WARNING: py:meth reference target not found: remove
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:537: WARNING: py:meth reference target not found: __del__
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:556: WARNING: py:meth reference target not found: __del__
/Users/sobolev/Desktop/cpython/Doc/library/weakref.rst:561: WARNING: py:meth reference target not found: __del__

📚 Documentation preview 📚: https://cpython-previews--109881.org.readthedocs.build/

@sobolevn sobolevn requested a review from hugovk September 26, 2023 06:42
@bedevere-app bedevere-app bot mentioned this pull request Sep 26, 2023
Open
@sobolevn sobolevn added docs Documentation in the Doc dir skip news labels Sep 26, 2023
@hugovk hugovk changed the title gh-101100: Fix shpinx warnings in Doc/library/weakref.rst gh-101100: Fix Sphinx warnings in Doc/library/weakref.rst Sep 26, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 26, 2023
hugovk
hugovk approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 7c61a36 into python:main Sep 26, 2023
24 checks passed
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7c61a361fc2e93375e22849fffbc20b60e94dbde 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2023
@sobolevn @miss-islington
pythongh-101100: Fix Sphinx warnings in Doc/library/weakref.rst (py…
65f9fd3 
…thonGH-109881)

(cherry picked from commit 7c61a36)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109883 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 26, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109884 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 26, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Sep 26, 2023
@sobolevn @hugovk
[3.12] pythongh-101100: Fix Sphinx warnings in `Doc/library/weakref.r…
358adc0 
…st` (pythonGH-109881).

(cherry picked from commit 7c61a36)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hugovk pushed a commit that referenced this pull request Sep 26, 2023
@miss-islington @sobolevn
[3.11] gh-101100: Fix Sphinx warnings in Doc/library/weakref.rst (G…
3ab0621 
…H-109881) (#109883)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Yhg1s pushed a commit that referenced this pull request Sep 26, 2023
@hugovk @sobolevn
[3.12] gh-101100: Fix Sphinx warnings in Doc/library/weakref.rst (G…
57ff216 
…H-109881) (#109884)

[3.12] gh-101100: Fix Sphinx warnings in `Doc/library/weakref.rst` (GH-109881).
(cherry picked from commit 7c61a36)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@sobolevn @csm10495
pythongh-101100: Fix Sphinx warnings in Doc/library/weakref.rst (py…
c8a95e2 
…thon#109881)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-101100: Fix Sphinx warnings in Doc/library/weakref.rst (py…
036b0d2 
…thon#109881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

@hugovk hugovk

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @miss-islington @hugovk