Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-109565: Fix concurrent.futures test_future_times_out() #109949

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 27, 2023

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows monotonic clock resolution is around 15.6 ms.

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
@vstinner vstinner enabled auto-merge (squash) September 27, 2023 08:26
@vstinner vstinner merged commit b1aebf1 into python:main Sep 27, 2023
16 checks passed
@vstinner vstinner deleted the cf_fix_test_future_times_out branch September 27, 2023 08:51
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b1aebf1e6576680d606068d17e2208259573e061 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2023
…onGH-109949)

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
(cherry picked from commit b1aebf1)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2023

GH-109952 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 27, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit b1aebf1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/5451) and take a look at the build logs.
  4. Check if the failure is related to this commit (b1aebf1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/78/builds/5451

Failed tests:

  • test_pty

Failed subtests:

  • test_openpty - test.test_pty.PtyTest.test_openpty

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 192, in test_openpty
    s2 = _readline(master_fd)
         ^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 68, in _readline
    return reader.readline()
           ^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_pty.py", line 105, in handle_sig
    self.fail("isatty hung")
AssertionError: isatty hung

@vstinner vstinner removed the needs backport to 3.11 only security fixes label Sep 27, 2023
@vstinner
Copy link
Member Author

Python 3.11 is not affected. In Python 3.11, the test is called test_zero_timeout() and doesn't test non-zero timeout.

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…on#109949)

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
…109949) (#109952)

gh-109565: Fix concurrent.futures test_future_times_out() (GH-109949)

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
(cherry picked from commit b1aebf1)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…on#109949)

as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants