Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29474: Improve documentation for weakref.WeakValueDictionary #11

Merged
merged 1 commit into from
Feb 11, 2017
Merged

bpo-29474: Improve documentation for weakref.WeakValueDictionary #11

merged 1 commit into from
Feb 11, 2017

Conversation

Mariatta
Copy link
Member

There were some grammatical errors in weakref.WeakValueDictionary
documentation.

This is to be applied to 2.7

@Mariatta
bpo-29474: Improve documentation for weakref.WeakValueDictionary
12fd14f 
There were some grammatical errors in weakref.WeakValueDictionary
documentation.

This is to be applied to 2.7
zware
zware approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting that the sentence makes sense in context, this does indeed fix the grammar. LGTM.

@zware zware merged commit 5c32988 into python:2.7 Feb 11, 2017
@Mariatta Mariatta deleted the bpo-29474py2 branch February 12, 2017 04:10
@Mariatta
Copy link
Member Author

Thanks for the reviews, @zware :)

paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
@paulmon
Merge pull request python#11 from paulmon/win-arm32-pip
2f233f6 
pip requires distutils
emmatyping added a commit to emmatyping/cpython that referenced this pull request Feb 24, 2020
@emmatyping
Do not make IOBase generic (python#11)
a05d9ae
@pablogsal pablogsal mentioned this pull request Jun 12, 2020
Closed
@shihai1991 shihai1991 mentioned this pull request Jun 23, 2020
Closed
@larryhastings larryhastings mentioned this pull request Jun 7, 2022
Closed
@itachaaa itachaaa mentioned this pull request Aug 22, 2022
Open
@mdboom mdboom mentioned this pull request Aug 25, 2022
Closed
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Nov 17, 2022
@bors @nanjekyejoannah
Merge python#11
8deb7c5 
11: Warn for function attributes r=ltratt a=nanjekyejoannah

Warn for function attributes

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
@mdboom mdboom mentioned this pull request Nov 22, 2022
Closed
@ziegenbalg ziegenbalg mentioned this pull request Nov 30, 2022
Closed
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@stasos24 stasos24 mentioned this pull request Oct 24, 2023
Closed
@williamhu020 williamhu020 mentioned this pull request Nov 5, 2023
Closed
@kcatss kcatss mentioned this pull request Nov 15, 2023
Open
@kcatss kcatss mentioned this pull request Jan 14, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 12, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @zware @the-knights-who-say-ni