-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-101100: Fix reference warnings for __enter__
and __exit__
#110112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look ok, but see #110118 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: #110118 (comment), I think we're good to merge.
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…t__`` (pythonGH-110112) (cherry picked from commit 63acf78) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…t__`` (pythonGH-110112) (cherry picked from commit 63acf78) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-111075 is a backport of this pull request to the 3.12 branch. |
GH-111076 is a backport of this pull request to the 3.11 branch. |
📚 Documentation preview 📚: https://cpython-previews--110112.org.readthedocs.build/