-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-104232: Fix sys.settrace
docs to reflect the reality
#110516
Conversation
Thanks for looking into it (this has always confused me too). |
Thanks @gaogaotiantian for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-111045 is a backport of this pull request to the 3.11 branch. |
Thanks @gaogaotiantian for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-111047 is a backport of this pull request to the 3.12 branch. |
In our current docs, we claim that:
That is not the case, and for as far as we know.
Returning
None
in the local trace function has no effect and it's already the de facto. There are at least 3 issues about this (#104232, #78980 and #56201) and it should not be that difficult to fix this. Rather than changing the behavior which could potentially break someone's code, we can simply change our docs because we never achieved what we claimed anyway, and people are fine with it.📚 Documentation preview 📚: https://cpython-previews--110516.org.readthedocs.build/