-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-85283: _stat extension now uses the limited C API #110711
Conversation
|
I approved as this seems trivial so "lets do it!", obviously figuring out the windows build excitement in CI needs to happen first. |
What's going on? Now Windows build fails with:
|
Ok, I found the root issue and wrote a fix: PR gh-110725. The problem comes from PyAPI_FUNC(), PyAPI_DATA() and PyMODINIT_FUNC macros which have a different implementation depending if the 3 Py_BUILD_CORE macros are defined or not. |
The _stat C extension is now built with the limited C API.
052d021
to
a0cc4f5
Compare
Merged, thanks for the review @gpshead and @erlend-aasland. |
…0711) pythongh-85283: _stat extension uses the limited C API The _stat C extension is now built with the limited C API.
The _stat C extension is now built with the limited C API.
📚 Documentation preview 📚: https://cpython-previews--110711.org.readthedocs.build/