Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111569: Fix critical sections test on WebAssembly #111897

Merged
merged 3 commits into from
Nov 9, 2023
Merged

gh-111569: Fix critical sections test on WebAssembly #111897

merged 3 commits into from
Nov 9, 2023

Commits on Nov 9, 2023

  1. pythongh-111569: Fix critical sections test on WebAssembly 

    This adds a macro `Py_CAN_START_THREADS` that corresponds to the Python
function `test.support.threading_helper.can_start_thread()`. WASI and
some Emscripten builds do not have a working pthread implementation.

This macro is used to guard the critical sections C API tests that
require a working threads implementation.
    @colesbury
    colesbury committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    aef9180 View commit details
    Browse the repository at this point in the history

  2. Use HAVE_PTHREAD_STUBS instead

    @colesbury
    colesbury committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fe38ff9 View commit details
    Browse the repository at this point in the history

  3. Go back to Py_CAN_START_THREADS

    @colesbury
    colesbury committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2ac2321 View commit details
    Browse the repository at this point in the history