-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-28929: Add to Misc/NEWS #112
Conversation
mention bpo-28929 in the Documentation section of: - What's New in Python 3.7.0 alpha 1? - What's New in Python 3.6.1 release candidate 1? - What's New in Python 3.5.4 release candidate 1? http://bugs.python.org/issue28929
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically don't worry about covering NEWS entries more than once in a single copy of the file since it's redundant information at that point; as long as someone reading the release notes in a release can see the news entry somewhere then that's enough.
Misc/NEWS
Outdated
@@ -700,6 +700,8 @@ C API | |||
Documentation | |||
------------- | |||
|
|||
- bpo-28929: Link the documentation to its source file on GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a period.
Misc/NEWS
Outdated
@@ -909,6 +911,8 @@ Windows | |||
Documentation | |||
------------- | |||
|
|||
- bpo-28929: Link the documentation to its source file on GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary as the same bit of information is picked up in the 3.7 release notes.
Misc/NEWS
Outdated
@@ -4095,6 +4099,17 @@ C API | |||
instead of TypeError on programmical error in parsing format string. | |||
|
|||
|
|||
What's New in Python 3.5.4 release candidate 1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also unnecessary.
Thanks @brettcannon :) |
I suppose it doesn't need backport then. But please re-add the labels if I'm mistaken. |
You can still backport into the appropriate sections, I'm just saying you don't need it more than once in the file at any one time. And I'm now on vacation so I'll let someone else approve. 😀 |
Ah ok I think I got it now 😅 Re-added the backport labels. Please enjoy your vacation! |
This commit merges the fix from C-Python pull request python#1066 (git commit 22e032a) for bpo-30028. Without this change $ ./python -m test.regrtest test_multiprocessing_fork fails. ($ ./python -m test.test_multiprocessing_fork is OK.) https://bitbucket.org/stackless-dev/stackless/issues/112
…s and test_xml_etree Disable the recently added test methods test_copy() and test_pickle() in test_dictviews, test_generators and test_xml_etree. Theses test assure that objects can't be copied or pickled, but Stackless can copy/pickle them. https://bitbucket.org/stackless-dev/stackless/issues/112
Fix the recently added test test_pdb.test_pdb_issue_20766. This test depends on undefined behaviour of C-Python (invalid value of frame.f_lineno if frame.f_trace is None). Stackless-Python behaves differently, if soft-switching is enabled. This change disables soft-switching for this test. https://bitbucket.org/stackless-dev/stackless/issues/112
…in ceval.c #define PY_LOCAL_AGGRESSIVE in ceval.c. Commit c3815b2f9943 undefined it by accident. https://bitbucket.org/stackless-dev/stackless/issues/112
Coroutines are a new feature of Python 3.5. Because their implementation is based on generators, we can pickle and unpickle them easily. https://bitbucket.org/stackless-dev/stackless/issues/112
Skip CPython test cases for coroutine pickling / copying. https://bitbucket.org/stackless-dev/stackless/issues/112
- Preserve the new generator attributes __qualname__ and __name__ on pickling https://bitbucket.org/stackless-dev/stackless/issues/112
- Skip the CPython test case test.test_pickle.*.test_local_lookup_error. This test checks, that pickling of a local function raises an exception. Stackless pickles the function by value. https://bitbucket.org/stackless-dev/stackless/issues/112
- Fix the CPython test case test.test_pickle.CompatPickleTests.test_exceptions https://bitbucket.org/stackless-dev/stackless/issues/112
- If C-pickle encounters a local function, save_global() now raises AttributeError instead of the documented PicklingError. This commits adapts the Stackless patch to kick in on AttributeError too. https://bitbucket.org/stackless-dev/stackless/issues/112
…erators Stackless has its own copy of the gen_send_ex function: slp_gen_send_ex() and gen_iternext_callback(). I added the PEP479 code to gen_iternext_callback(). https://bitbucket.org/stackless-dev/stackless/issues/112
Fix various issues introduced by merging the PEP 492 implementation from default. https://bitbucket.org/stackless-dev/stackless/issues/112
Fix the reference counting in the slp_eval_frame_with_cleanup code path. It was broken by commit e39fd5a8501a. https://bitbucket.org/stackless-dev/stackless/issues/112
…ators Fix the handling of StopIteration raised from generators. It was broken by commit 2771a0ac806b. https://bitbucket.org/stackless-dev/stackless/issues/112
This commit merges the fix from C-Python pull request python#1066 (git commit 22e032a) for bpo-30028. Without this change $ ./python -m test.regrtest test_multiprocessing_fork fails. ($ ./python -m test.test_multiprocessing_fork is OK.) https://bitbucket.org/stackless-dev/stackless/issues/112 (grafted from bda8a9d487da7cfbe4357d5c4c7635e0de19c6af)
- Change the product and file names to Stackless (Python). - Add Stackless include files - Update the Product and Download URLs (cherry picked from commit 0c1f53c)
- Change the product and file names to Stackless (Python). - Add Stackless include files - Update the Product and Download URLs
Change the behavior for when deciding when miss-islington should merge the PR. Previously it checks if the PR has one core dev who approved the PR. But that is unreliable because the review may be dismissed later, or another core dev might decide not to backport the PR anymore. The "awaiting merge" label is a better indicator that the PR is ready for merge. Adjust tests. Fixes python/miss-islington#62
Mention bpo-28929 in the Documentation section of:
http://bugs.python.org/issue28929