gh-109413: libregrtest: enable mypy's --strict-optional check on most files
#112586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on most files
vstinner
reviewed
Dec 1, 2023
AlexWaygood
commented
Dec 1, 2023
Co-authored-by: Victor Stinner <vstinner@python.org>
|
On hold until #112588 is merged |
vstinner
reviewed
Dec 1, 2023
Co-authored-by: Victor Stinner <vstinner@python.org>
AlexWaygood
added
needs backport to 3.11
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Dec 1, 2023
… on most files (python#112586) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-112602 is a backport of this pull request to the 3.12 branch. |
|
I added the "needs backport to 3.11" label to the 3.12 branch to take care of the 3.11 backport. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2023
…` check on most files (pythonGH-112586) (pythonGH-112602) pythongh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (pythonGH-112586) (cherry picked from commit 36dbebe) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
AlexWaygood
added a commit
that referenced
this pull request
Dec 1, 2023
…l` check on most files (GH-112586) (GH-112602) (#112603) [3.12] gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (GH-112602) gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (cherry picked from commit 36dbebe) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… on most files (python#112586) Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… on most files (python#112586) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy's
--strict-optionalcheck is one of its most important checks, and it's enabled by default when you run mypy. It warns you if it infers that an object might be of typeFoo | Noneat runtime, even though the code is only guaranteed to work if the object is an instance ofFoo.We currently have
--strict-optionaldisabled on several files, as there were too many errors to deal with initially, and the priority was to have mypy enabled in CI so that we could work on improving the type annotations incrementally. This PR re-enables--strict-optionalon four files where it's easy to do so.