Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs #112737

Merged
merged 2 commits into from
Dec 5, 2023
Merged

gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs #112737

merged 2 commits into from
Dec 5, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Dec 5, 2023 •
edited by github-actions bot
Loading

Many still remain, but this gets rid of 40-or-so warnings

📚 Documentation preview 📚: https://cpython-previews--112737.org.readthedocs.build/

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Dec 5, 2023
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 5, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 5, 2023
Open
@AlexWaygood AlexWaygood marked this pull request as ready for review December 5, 2023 01:03
serhiy-storchaka
serhiy-storchaka reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but frozenset.add.

Doc/reference/datamodel.rst Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexWaygood AlexWaygood merged commit 2f20caf into python:main Dec 5, 2023
25 checks passed
@AlexWaygood AlexWaygood deleted the datamodel-nitpicks branch December 5, 2023 09:59
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2023
@AlexWaygood @miss-islington
pythongh-101100: Fix many easily solvable Sphinx nitpicks in the data…
c10c136 
…model docs (pythonGH-112737)

(cherry picked from commit 2f20caf)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2023

GH-112748 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 5, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2023

GH-112749 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2023
@AlexWaygood @miss-islington
pythongh-101100: Fix many easily solvable Sphinx nitpicks in the data…
e092653 
…model docs (pythonGH-112737)

(cherry picked from commit 2f20caf)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 5, 2023
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
@miss-islington @AlexWaygood
[3.12] gh-101100: Fix many easily solvable Sphinx nitpicks in the dat…
68f05dd 
…amodel docs (GH-112737) (#112748)

gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs (GH-112737)
(cherry picked from commit 2f20caf)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
@miss-islington @AlexWaygood
[3.11] gh-101100: Fix many easily solvable Sphinx nitpicks in the dat…
80c314c 
…amodel docs (GH-112737) (#112749)

gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs (GH-112737)
(cherry picked from commit 2f20caf)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood mentioned this pull request Jan 19, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @aisk
pythongh-101100: Fix many easily solvable Sphinx nitpicks in the data…
58b5b6c 
…model docs (python#112737)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-101100: Fix many easily solvable Sphinx nitpicks in the data…
6c0a967 
…model docs (python#112737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @serhiy-storchaka