Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix Sphinx nitpicks in library/traceback.rst #113106

Merged
merged 2 commits into from
Dec 14, 2023
Merged

gh-101100: Fix Sphinx nitpicks in library/traceback.rst #113106

merged 2 commits into from
Dec 14, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Dec 14, 2023 •
edited by github-actions bot
Loading

  • Fix Sphinx nitpicks (this required properly documenting the attributes of FrameSummary instances)
  • Add links where appropriate to other parts of CPython's documentation
  • Remove distracting links that just took the reader to the section they were already reading

📚 Documentation preview 📚: https://cpython-previews--113106.org.readthedocs.build/

@AlexWaygood AlexWaygood added skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Dec 14, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 14, 2023
Open
AlexWaygood
AlexWaygood commented Dec 14, 2023
View reviewed changes
Doc/library/exceptions.rst
which an the exception was raised:
which the exception was raised:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just fixes a typo I accidentally introduced in #113057

@AlexWaygood AlexWaygood enabled auto-merge (squash) December 14, 2023 14:03
@AlexWaygood
Copy link
Member Author

Thanks @serhiy-storchaka!

@AlexWaygood AlexWaygood merged commit d9e1b57 into python:main Dec 14, 2023
23 checks passed
@AlexWaygood AlexWaygood deleted the traceback-docs branch December 14, 2023 14:10
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2023
@AlexWaygood @miss-islington
pythongh-101100: Fix Sphinx nitpicks in library/traceback.rst (pyth…
44b1b69 
…onGH-113106)

(cherry picked from commit d9e1b57)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2023

GH-113111 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 14, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 14, 2023

GH-113112 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2023
@AlexWaygood @miss-islington
pythongh-101100: Fix Sphinx nitpicks in library/traceback.rst (pyth…
ff9640a 
…onGH-113106)

(cherry picked from commit d9e1b57)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 14, 2023
AlexWaygood added a commit that referenced this pull request Dec 14, 2023
@miss-islington @AlexWaygood
[3.11] gh-101100: Fix Sphinx nitpicks in library/traceback.rst (GH-…
99c8d16 
…113106) (#113112)

gh-101100: Fix Sphinx nitpicks in `library/traceback.rst` (GH-113106)
(cherry picked from commit d9e1b57)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 14, 2023
@miss-islington @AlexWaygood
[3.12] gh-101100: Fix Sphinx nitpicks in library/traceback.rst (GH-…
c6c559a 
…113106) (#113111)

gh-101100: Fix Sphinx nitpicks in `library/traceback.rst` (GH-113106)
(cherry picked from commit d9e1b57)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023
@AlexWaygood @corona10
pythongh-101100: Fix Sphinx nitpicks in library/traceback.rst (pyth…
20757d7 
…on#113106)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @aisk
pythongh-101100: Fix Sphinx nitpicks in library/traceback.rst (pyth…
7aa895f 
…on#113106)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-101100: Fix Sphinx nitpicks in library/traceback.rst (pyth…
d5e855d 
…on#113106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @serhiy-storchaka