Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103092: Port some _ctypes data types to heap types (alt) #113774

Closed
wants to merge 1 commit into from
Closed

gh-103092: Port some _ctypes data types to heap types (alt) #113774

wants to merge 1 commit into from

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Jan 6, 2024 •
edited
Loading

An alternative PR to #113630. This version will keep the behavior unchanged by making the MOD_ADD_TYPE() macro hack the metatype's tp_new slot.

@bedevere-app bedevere-app bot mentioned this pull request Jan 6, 2024
Open
25 tasks
@neonene neonene mentioned this pull request Jan 6, 2024
Closed
@encukou
Copy link
Member

encukou commented Jan 8, 2024

If we don't have API to solve this without the hack, I think it's better to keep _ctypes unported.
Let's keep discussion in #113630.

@encukou encukou closed this Jan 8, 2024
@neonene neonene deleted the ctypes_alt branch January 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonene @encukou