Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Improve description of GET_LEN opcode #114583

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Doc: Improve description of GET_LEN opcode #114583

merged 1 commit into from
Oct 8, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jan 26, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir labels Jan 26, 2024
@Eclips4 Eclips4 requested a review from brandtbucher January 26, 2024 11:55
@Eclips4 Eclips4 changed the title Doc: Improve description of GET_FOR opcode Doc: Improve description of GET_LEN opcode Jan 26, 2024
@Eclips4
Copy link
Member Author

Eclips4 commented Mar 9, 2024

ping @brandtbucher

@vstinner
Copy link
Member

vstinner commented Jun 7, 2024

cc @iritkatriel

@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 14, 2024
vstinner
vstinner approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit e8773e5 into python:main Oct 8, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
@Eclips4 @miss-islington
Doc: Improve description of GET_LEN opcode (pythonGH-114583)
79021f8 
(cherry picked from commit e8773e5)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
@Eclips4 @miss-islington
Doc: Improve description of GET_LEN opcode (pythonGH-114583)
a72c237 
(cherry picked from commit e8773e5)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2024

GH-125102 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2024

GH-125103 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 8, 2024
kumaraditya303 pushed a commit that referenced this pull request Oct 8, 2024
@miss-islington @Eclips4
[3.13] Doc: Improve description of GET_LEN opcode (GH-114583) (#1…
0a63c66 
…25102)

Doc: Improve description of ``GET_LEN`` opcode (GH-114583)
(cherry picked from commit e8773e5)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
kumaraditya303 pushed a commit that referenced this pull request Oct 8, 2024
@miss-islington @Eclips4
[3.12] Doc: Improve description of GET_LEN opcode (GH-114583) (#1…
65272a3 
…25103)

Doc: Improve description of ``GET_LEN`` opcode (GH-114583)
(cherry picked from commit e8773e5)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4 Eclips4 deleted the get-len-doc branch October 8, 2024 16:03
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
@Eclips4 @efimov-mikhail
Doc: Improve description of GET_LEN opcode (python#114583)
8e98322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eclips4 @vstinner @kumaraditya303