Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113317: Argument Clinic: don't use global state in warn() and fail() #115510

Merged
merged 2 commits into from
Feb 15, 2024
Merged

gh-113317: Argument Clinic: don't use global state in warn() and fail() #115510

merged 2 commits into from
Feb 15, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 15, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 15, 2024
Closed
@erlend-aasland erlend-aasland mentioned this pull request Feb 15, 2024
Closed
sobolevn
sobolevn approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erlend-aasland erlend-aasland merged commit 7f074a7 into python:main Feb 15, 2024
39 checks passed
@erlend-aasland erlend-aasland deleted the clinic/get-rid-of-global-clinic-in-fail-and-warn branch February 15, 2024 12:22
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

This was referenced Feb 15, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @sobolevn