Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115491: Keep some fields valid across allocations (free-threading) #115573

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 16, 2024

This avoids mimalloc filling the memory occupied by ob_tid, ob_ref_local, and ob_ref_shared with debug bytes (e.g., 0xDD) the free-threaded build.

…ading)

This avoids filling the memory occupied by ob_tid, ob_ref_local, and
ob_ref_shared with debug bytes (e.g., 0xDD) in mimalloc in the
free-threaded build.
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the warnings on Windows? Otherwise LGTM

@colesbury colesbury merged commit cc82e33 into python:main Feb 20, 2024
33 checks passed
@colesbury colesbury deleted the gh-115491-debug-fill-mimalloc branch February 20, 2024 15:37
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…ading) (python#115573)

This avoids filling the memory occupied by ob_tid, ob_ref_local, and
ob_ref_shared with debug bytes (e.g., 0xDD) in mimalloc in the
free-threaded build.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…ading) (python#115573)

This avoids filling the memory occupied by ob_tid, ob_ref_local, and
ob_ref_shared with debug bytes (e.g., 0xDD) in mimalloc in the
free-threaded build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants