-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix Sphinx warnings in whatsnew/3.2.rst
#115580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one question:
Doc/whatsnew/3.2.rst
Outdated
@@ -1336,7 +1336,7 @@ Decimal('1.100000000000000088817841970012523233890533447265625') | |||
Fraction(2476979795053773, 2251799813685248) | |||
|
|||
Another useful change for the :mod:`decimal` module is that the | |||
:attr:`Context.clamp` attribute is now public. This is useful in creating | |||
:attr:`Context.clamp <decimal.Context>` attribute is now public. This is useful in creating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public... but apparently still undocumented? Should this maybe be left as is, and added to this list for now?
Lines 273 to 279 in 318f219
# Attributes/methods/etc. that definitely should be documented better, | |
# but are deferred for now: | |
('py:attr', '__annotations__'), | |
('py:meth', '__missing__'), | |
('py:attr', '__wrapped__'), | |
('py:meth', 'index'), # list.index, tuple.index, etc. | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-115589 is a backport of this pull request to the 3.12 branch. |
GH-115590 is a backport of this pull request to the 3.11 branch. |
… (#115589) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
… (#115590) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
…5580) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
…5580) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fix 49 warnings:
📚 Documentation preview 📚: https://cpython-previews--115580.org.readthedocs.build/