Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115892: Fix ntpath.splitext() with UNC paths #115996

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 27, 2024

os.path.splitext() on Windows no longer splits an "extension" from the server or share name in the UNC path.

os.path.splitext() on Windows no longer splits an "extension" from
the server or share name in the UNC path.
@zooba
Copy link
Member

zooba commented Nov 12, 2024

As I posted on the issue, I don't particularly want splitext to depend on the start of the string (or on the entire string, if you want to view it that way). If the caller is splitext-ing something that isn't a path to a file, they'll get invalid results (e.g. if it's a directory). I don't think it's worth changing from an implementation that only considers the end of the string.

(I post this half to remind myself next time I come and look at the PR, because I nearly just hit "merge" before remembering what this was about 😆 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants