Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghpython-116307: Proper fix for 'mod' leaking across importlib tests #116678

Closed
wants to merge 35 commits into from
Closed

ghpython-116307: Proper fix for 'mod' leaking across importlib tests #116678

wants to merge 35 commits into from

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 12, 2024

  • Tests fail if --disable-test-modules is supplied #116303: Skip some sqlite3 tests if testcapi is unavailable
  • Skip more tests
  • Split up sqlite3 tests
  • Amend previous commit
  • Use import_helper iso. requires_limited_api
  • More skips
  • Fix gc and weakref tests
  • Remove local debug stuff
  • Fix test_os
  • Fixup stable_abi.py
  • Fixup run_in_subinterp
  • Fixup test_call
  • Fixup test_audit
  • Fix some _testsinglephase issues
  • Address review: use setUpClass in test_call; don't skip everything
  • Address review: no need to skip in tearDown
  • Address review: check import at the top of test_threading.test_frame_tstate_tracing
  • Fixup some test.support helpers
  • Fixup test_coroutines
  • Fixup test_threading
  • Fixup test_repl
  • Fixup test_monitoring
  • Amend test_embed
  • Amend test_audit
  • Fix test_socket
  • Resolve test_exceptions nicer
  • Use import_helper in test_importlib
  • Fixup test_embed
  • Revert spurious docs change
  • Workaround: use a different test module name in test_module_resources
  • gh-116303: Skip test module dependent tests if test modules are disabled #116307: Create a new import helper 'isolated modules' and use that instead of 'Clean Import' to ensure that tests from importlib_resources don't leave modules in sys.modules.

@erlend-aasland
pythongh-116303: Skip some sqlite3 tests if testcapi is unavailable
9b3f0f7
@erlend-aasland
Skip more tests
0f6f74e 
- Lib/test/support/__init__.py
- Lib/test/test_audit.py
- Lib/test/test_gdb/test_misc.py
- Lib/test/test_inspect/test_inspect.py
- Lib/test/test_pydoc/test_pydoc.py
@erlend-aasland
Split up sqlite3 tests
2f750c3
@erlend-aasland
Amend previous commit
7c4477d
@erlend-aasland
Pull in main
a9c6f62
@erlend-aasland
Use import_helper iso. requires_limited_api
cdc6df4
@erlend-aasland
More skips
d05dcd7
@erlend-aasland
Fix gc and weakref tests
cb7cff4
@erlend-aasland
Remove local debug stuff
ad5e3b6
@erlend-aasland
Fix test_os
cdb8bf4
@erlend-aasland
Fixup stable_abi.py
e4a30b0
@erlend-aasland
Fixup run_in_subinterp
fabb007
@erlend-aasland
Fixup test_call
c51dafa
@erlend-aasland
Fixup test_audit
c3f9c99
@erlend-aasland
Fix some _testsinglephase issues
fde9548
@erlend-aasland
Address review: use setUpClass in test_call; don't skip everything
ea72ced
@erlend-aasland
Address review: no need to skip in tearDown
628896c
@erlend-aasland
Address review: check import at the top of test_threading.test_frame_…
88c6739 
…tstate_tracing
@erlend-aasland
Fixup some test.support helpers
c02cd6f
@erlend-aasland
Fixup test_coroutines
d49532b
@erlend-aasland
Fixup test_threading
2427111
@erlend-aasland
Fixup test_repl
25d0999
@erlend-aasland
Fixup test_monitoring
bdd8cff
@erlend-aasland
Amend test_embed
ee9fa51
@erlend-aasland
Amend test_audit
a47c5ff
@erlend-aasland
Fix test_socket
d84a5c4
@erlend-aasland
Resolve test_exceptions nicer
e877ffb
@erlend-aasland
Merge branch 'main' into sqlite/testcapi
1ec0c66
@erlend-aasland
Use import_helper in test_importlib
afa58a9
@erlend-aasland
Fixup test_embed
760c6cb
@jaraco jaraco mentioned this pull request Mar 12, 2024
Merged
@jaraco
Copy link
Member Author

jaraco commented Mar 12, 2024

Needed to rebase first. Sorry for the noise.

@jaraco jaraco closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaraco @erlend-aasland