Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90095: Ignore empty lines and comments in .pdbrc #116834

Merged
merged 3 commits into from
Mar 15, 2024
Merged

gh-90095: Ignore empty lines and comments in .pdbrc #116834

merged 3 commits into from
Mar 15, 2024

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Mar 14, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 14, 2024
Closed
@gaogaotiantian gaogaotiantian added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 14, 2024
@iritkatriel iritkatriel merged commit a50cf6c into python:main Mar 15, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @gaogaotiantian for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2024
@gaogaotiantian @miss-islington
pythongh-90095: Ignore empty lines and comments in .pdbrc (pythonGH…
1cbc90e 
…-116834)

(cherry picked from commit a50cf6c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2024

GH-116854 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2024
@gaogaotiantian @miss-islington
pythongh-90095: Ignore empty lines and comments in .pdbrc (pythonGH…
a93a62a 
…-116834)

(cherry picked from commit a50cf6c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2024

GH-116855 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 15, 2024
iritkatriel pushed a commit that referenced this pull request Mar 15, 2024
@miss-islington @gaogaotiantian
[3.12] gh-90095: Ignore empty lines and comments in .pdbrc (GH-116834…
abd0798 
…) (#116854)

gh-90095: Ignore empty lines and comments in `.pdbrc` (GH-116834)
(cherry picked from commit a50cf6c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull request Mar 15, 2024
@miss-islington @gaogaotiantian
[3.11] gh-90095: Ignore empty lines and comments in .pdbrc (GH-116834…
eaefa0b 
…) (#116855)

gh-90095: Ignore empty lines and comments in `.pdbrc` (GH-116834)
(cherry picked from commit a50cf6c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@gaogaotiantian gaogaotiantian deleted the fix-pdbrc-ignore-line branch March 15, 2024 17:31
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@gaogaotiantian @vstinner
pythongh-90095: Ignore empty lines and comments in .pdbrc (python#1…
4ccb227 
…16834)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@gaogaotiantian @adorilson
pythongh-90095: Ignore empty lines and comments in .pdbrc (python#1…
7fe3061 
…16834)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@gaogaotiantian @diegorusso
pythongh-90095: Ignore empty lines and comments in .pdbrc (python#1…
3c159c5 
…16834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaogaotiantian @iritkatriel