Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117381: Fix error message for ntpath.commonpath #117382

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Mar 29, 2024

@nineteendo nineteendo mentioned this pull request Mar 29, 2024
16 tasks
@nineteendo nineteendo marked this pull request as ready for review March 29, 2024 21:50
@aisk
Copy link
Contributor

aisk commented Mar 31, 2024

I think maybe we need a test to ensure the expected error will be raised.

@nineteendo
Copy link
Contributor Author

nineteendo commented Mar 31, 2024

There are now assertRaisesRegex tests for all these cases:

image

Created with https://csacademy.com/app/graph_editor (mermaid can't connect horizontally):

D:/foo C:/foo
D:/foo C:foo
D:foo C:/foo
D:foo C:foo
C:/foo C:foo
C:/foo /foo
C:/foo foo
C:foo /foo
C:foo foo
/foo foo

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 2ec6bb4 into python:main Apr 3, 2024
35 checks passed
@nineteendo nineteendo deleted the fix-ntpath.commonpath branch April 3, 2024 13:11
@nineteendo nineteendo restored the fix-ntpath.commonpath branch April 3, 2024 14:25
@nineteendo nineteendo deleted the fix-ntpath.commonpath branch April 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants