bpo-20523: pdb.Pdb can read the global ~/.pdbrc file on Windows 7

[matrixise]

https://bugs.python.org/issue20523

[tirkarthi]

Please also see open PR for the issue : #11847

[matrixise]

@tirkarthi yep, thanks

[matrixise]

@tirkarthi what can I do? close my PR or add a test for my code. what do you think?

[tirkarthi]

what can I do? close my PR or add a test for my code. what do you think?

I am not really sure about the correctness of either PRs. I just wanted to add the related open PR.

[Ishaan28malik]

Works well

[augustogoulart]

This is just me being picky about comments, so use (or not) the following at your will:

1 - Although this has been vastly done in CPython, I'm personally against including the issue number (bpo-20523) at the code changes. This practice pollutes the de code and thinking forward, I wouldn't like to see a million bpo's in the source code ten years from now.

2 - The second line use os.path.expanduser() is redundant. A good comment should tell why that change is necessary, and not how you are accomplishing that. Your code should be readable enough for anyone to figure out the hows. Which in this case, it's already readable enough.

[matrixise]

@augustogoulart

1. we have 431 "bpo-XYZ: " in the code of CPython.
2. I explain the reason of os.path.expanduser, because $HOME does not exist on Windows 7.

[blueyed]

I would close this in favor of #11847, which is older and has a test.
AFAIK code was changed according to feedback from @matrixise, so should be contributed there maybe.

[matrixise]

I close this PR because I have discussed with @tdhopper about his PR.