Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Module_SetGIL #118645

Merged
merged 1 commit into from
May 6, 2024
Merged

gh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Module_SetGIL #118645

merged 1 commit into from
May 6, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented May 6, 2024 •
edited by github-actions bot
Loading

The PyUnstable prefix has defined semantics and workflow, and generates a note in the docs:

image

📚 Documentation preview 📚: https://cpython-previews--118645.org.readthedocs.build/

@encukou encukou requested a review from colesbury May 6, 2024 12:48
@bedevere-app bedevere-app bot mentioned this pull request May 6, 2024
Closed
@encukou encukou mentioned this pull request May 6, 2024
Merged
@colesbury colesbury requested a review from swtaarrs May 6, 2024 15:36
colesbury
colesbury approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @swtaarrs

swtaarrs
swtaarrs approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@swtaarrs swtaarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@encukou encukou merged commit 417dd3a into python:main May 6, 2024
40 checks passed
@encukou encukou deleted the experimental_unstable branch May 6, 2024 16:59
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@encukou @SonicField
pythongh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Mod…
7678b39 
…ule_SetGIL (pythonGH-118645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@swtaarrs swtaarrs swtaarrs approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @swtaarrs @colesbury