gh-117657: Acquire a critical section around SemLock.__{enter,exit}__
#118812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
colesbury
approved these changes
May 9, 2024
|
Thanks @mpage for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
…exit}__` (pythonGH-118812) These methods are purely wrappers around `Semlock.{acquire,release}`, which expect a critical section to be held. (cherry picked from commit c30d8e5) Co-authored-by: mpage <mpage@meta.com>
|
GH-118856 is a backport of this pull request to the 3.13 branch. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
…exit}__` (python#118812) These methods are purely wrappers around `Semlock.{acquire,release}`, which expect a critical section to be held.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are purely wrappers around
Semlock.{acquire,release}, which expect a critical section to be held.Sample race reported by TSAN.